mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Simone Weiss <simone.weiss@fau.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
	lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org,
	helene.gsaenger@studium.fau.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Redone: dgnc/digi.h: checkpatch: Macros in enclosed
Date: Tue, 23 Dec 2014 08:29:11 -0800	[thread overview]
Message-ID: <20141223162911.GB4273@kroah.com> (raw)
In-Reply-To: <1419343871-21735-1-git-send-email-simone.weiss@fau.de>

On Tue, Dec 23, 2014 at 03:11:11PM +0100, Simone Weiss wrote:
> I've redone the previous patch as I have also forgotten a macro.

That's a horrible changelog entry, what does it mean?

And why the "redone" in the subject, that would force me to edit it by
hand, right?

Please don't do that, you want to make it as easy as possible for me to
accept your patches, right now it's impossible to.

greg k-h

  parent reply	other threads:[~2014-12-23 16:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22  1:17 [PATCH 0/6] dgnc: patches that fix checkpatch issues Simone Weiss
2014-12-22  1:17 ` [PATCH 1/6] dgnc/dgnc_cls.h: checkpatch: fixed long lines by moving comments Simone Weiss
2014-12-22  1:17 ` [PATCH 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of pr_err insted of printk Simone Weiss
2014-12-22  2:00   ` Greg KH
2014-12-22 18:43     ` [PATCH] [PATCH v2 2/6] dgnc/dgnc_sysfs.c: checkpatch: Use of dev_err ? instead " Simone Weiss
2014-12-22 19:11       ` Greg KH
2014-12-22  1:17 ` [PATCH 3/6] dgnc/dpacompat.h: checkpatch: fixed long lines bei moving comments Simone Weiss
2015-01-17 23:03   ` Greg KH
2014-12-22  1:17 ` [PATCH 4/6] dgnc/dpacompat.h: checkpatch: Changend complex macros (enclosed parantheses) Simone Weiss
2014-12-22 19:04   ` [PATCH] dgnc/digi.h: " Simone Weiss
2014-12-22 23:50     ` Greg KH
2014-12-23 14:11       ` [PATCH v2] Redone: dgnc/digi.h: checkpatch: Macros in enclosed Simone Weiss
2014-12-23 14:16         ` Dan Carpenter
2014-12-23 16:29         ` Greg KH [this message]
2014-12-22  1:17 ` [PATCH 5/6] dgnc/dgnc_neo.c: checkpatch: fixed long lines Simone Weiss
2014-12-22  1:17 ` [PATCH 6/6] dgnc/dgnc_driver.h: checkpatch: fixed lines over 80 characters Simone Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141223162911.GB4273@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=helene.gsaenger@studium.fau.de \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simone.weiss@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome