From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbaLXUSg (ORCPT ); Wed, 24 Dec 2014 15:18:36 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:43642 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbaLXUSf (ORCPT ); Wed, 24 Dec 2014 15:18:35 -0500 Date: Wed, 24 Dec 2014 15:18:28 -0500 (EST) Message-Id: <20141224.151828.1613041308360795454.davem@davemloft.net> To: pshelar@nicira.com Cc: fengguang.wu@intel.com, kbuild-all@01.org, dev@openvswitch.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] openvswitch: fix odd_ptr_err.cocci warnings From: David Miller In-Reply-To: References: <201412241437.BpaCtsIE%fengguang.wu@intel.com> <20141224064138.GA11360@athens> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Dec 2014 12:18:34 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pravin Shelar Date: Wed, 24 Dec 2014 10:49:22 -0800 > On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot > wrote: >> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 189 >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Semantic patch information: >> There can be false positives in the patch case, where it is the call >> IS_ERR that is wrong. >> >> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci >> >> CC: Pravin B Shelar >> Signed-off-by: Fengguang Wu > > Thanks for the fix. > > Acked-by: Pravin B Shelar Applied, thanks.