From: Baruch Siach <baruch@tkos.co.il>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] irqchip: Conexant CX92755 interrupts controller driver
Date: Wed, 24 Dec 2014 08:16:57 +0200 [thread overview]
Message-ID: <20141224061657.GI2481@sapphire.tkos.co.il> (raw)
In-Reply-To: <16151065.LjzHK8TaOo@wuerfel>
Hi Arnd,
On Tue, Dec 23, 2014 at 10:02:18PM +0100, Arnd Bergmann wrote:
> On Tuesday 23 December 2014 09:58:42 Baruch Siach wrote:
> > +static void __exception_irq_entry digicolor_handle_irq(struct pt_regs *regs)
> > +{
> > + u32 status, hwirq;
> > +
> > + do {
> > + status = readl(digicolor_irq_base + IC_INT0STATUS_LO);
> > + if (status) {
> > + hwirq = ffs(status) - 1;
> > + } else {
> > + status = readl(digicolor_irq_base + IC_INT0STATUS_XLO);
> > + if (status)
> > + hwirq = ffs(status) - 1 + 32;
> > + else
> > + return;
> > + }
> > +
> > + handle_domain_irq(digicolor_irq_domain, hwirq, regs);
> > + } while (1);
> > +}
> >
>
> Have you tried using the generic_irqchip code for this? The hardware
> seems simple enough.
Thanks for the tip. I'll look into converting to GENERIC_IRQ_CHIP for next
version.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-12-24 6:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 7:58 [PATCH 0/8] ARM: Conexant Digicolor CX92755 SoC support Baruch Siach
2014-12-23 7:58 ` [PATCH 1/8] ARM: initial support for Conexant Digicolor CX92755 SoC Baruch Siach
2014-12-23 7:58 ` [PATCH 2/8] ARM: digicolor: add low level debug support Baruch Siach
2014-12-23 21:00 ` Arnd Bergmann
2014-12-24 6:05 ` Baruch Siach
2014-12-23 7:58 ` [PATCH 3/8] ARM: digicolor: add minimal device tree description Baruch Siach
2014-12-23 7:58 ` [PATCH 4/8] ARM: devicetree: document supported Conexant Digicolor SoC Baruch Siach
2014-12-23 7:58 ` [PATCH 5/8] irqchip: Conexant CX92755 interrupts controller driver Baruch Siach
2014-12-23 21:02 ` Arnd Bergmann
2014-12-24 6:16 ` Baruch Siach [this message]
2014-12-23 7:58 ` [PATCH 6/8] irqchip: devicetree: document Conexant Digicolor irq binding Baruch Siach
2014-12-23 7:58 ` [PATCH 7/8] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2014-12-23 7:58 ` [PATCH 8/8] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2014-12-23 21:03 ` [PATCH 0/8] ARM: Conexant Digicolor CX92755 SoC support Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141224061657.GI2481@sapphire.tkos.co.il \
--to=baruch@tkos.co.il \
--cc=arnd@arndb.de \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®