Re: [PATCH] skein: checkpatch: trailing whitespace

[Jason Cooper <jason@lakedaemon.net>]

Andreas,

On Tue, Dec 30, 2014 at 12:33:34AM +0100, Andreas Siegling wrote:
> This small patch will fix the trailing whitespace in
> drivers/staging/skein/skein_generic.c.
> 
> After applying the patch, there will only remain the checkpatch warning:
> 	WARNING: Single statement macros should not use a do {} while (0) loop
> in files which are in the directory drivers/staging/skein/
> 
> Signed-off-by: Andreas Siegling <andreas.siegling@fau.de>
> Signed-off-by: Zhutao Lu <lvzhutao@gmail.com>

Why do you have have two S-o-b's?

> ---
>  drivers/staging/skein/skein_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 85bd7d0..4eaae1d 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -191,7 +191,7 @@ static int __init skein_generic_init(void)
>  
>  	return 0;
>  
> -		
> +

Hmm, this extra line should just be deleted.

thx,

Jason.

>  unreg512:
>  	crypto_unregister_shash(&alg512);
>  unreg256:
> -- 
> 1.9.1
>