From: Borislav Petkov <bp@alien8.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/boot/early_serial_console: Remove unnecessary check
Date: Tue, 30 Dec 2014 16:48:08 +0100 [thread overview]
Message-ID: <20141230154808.GA21238@nazgul.tnic> (raw)
In-Reply-To: <1419946102-17175-1-git-send-email-kuleshovmail@gmail.com>
On Tue, Dec 30, 2014 at 07:28:22PM +0600, Alexander Kuleshov wrote:
> There is already the same check before.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/x86/boot/early_serial_console.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> index 5df2869..62abcc8 100644
> --- a/arch/x86/boot/early_serial_console.c
> +++ b/arch/x86/boot/early_serial_console.c
> @@ -74,8 +74,7 @@ static void parse_earlyprintk(void)
> static const int bases[] = { 0x3f8, 0x2f8 };
> int idx = 0;
>
> - if (!strncmp(arg + pos, "ttyS", 4))
> - pos += 4;
You might need a comment to explain the advancing of pos to people who
look at this in the future, i.e. something like
/* += strlen("ttyS"); */
pos += 4;
>
> if (arg[pos++] == '1')
> idx = 1;
--
Regards/Gruss,
Boris.
--
next prev parent reply other threads:[~2014-12-30 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 13:28 Alexander Kuleshov
2014-12-30 15:48 ` Borislav Petkov [this message]
2014-12-30 16:58 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230154808.GA21238@nazgul.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®