From: Andreas Mohr <andi@lisas.de>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: "crmafra@gmail.com" <crmafra@gmail.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andreas.noever@gmail.com" <andreas.noever@gmail.com>,
"crmafra2@gmail.com" <crmafra2@gmail.com>,
rafael.j.wysocki@intel.com
Subject: Re: Bisected regression from 3.17 still present in 3.19-rc1
Date: Thu, 1 Jan 2015 21:40:45 +0100 [thread overview]
Message-ID: <20150101204045.GA14006@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <1419939412.25226.2.camel@nebula.com>
Matthew Garrett wrote:
> There's your problem. The Darwin call results in the firmware exposing
> the battery via SBS, not as an ACPI control method battery. Enable
> CONFIG_ACPI_SBS and you should be good.
Hmm, do I smell a possible usability case here?
Two choices:
a) declare a non-CONFIG_ACPI_SBS kernel
to be a "broken/inconsistent configuration"
(e.g. when used with a "Darwin" personality)
which thus will "simply not work"
(--> limitation is "by design"),
thus simply give up
b) declare CONFIG_ACPI_SBS to be cleanly optional/dynamic,
and then in case missing CONFIG_ACPI_SBS happens to be requested
try to give hints that it is missing
a) may easily be fully acceptable, but if b) is deemed better,
then perhaps there are ways
(such as failing calls --> generate log error message, ...)
to nicely determine/diagnose/report this issue.
Andreas Mohr
prev parent reply other threads:[~2015-01-01 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 18:54 Carlos R. Mafra
2014-12-29 21:49 ` Rafael J. Wysocki
2014-12-29 21:57 ` Carlos R. Mafra
2014-12-29 22:20 ` Andreas Noever
2014-12-29 22:53 ` Carlos R. Mafra
2014-12-30 1:28 ` Matthew Garrett
2014-12-30 10:16 ` Carlos R. Mafra
2014-12-30 11:36 ` Matthew Garrett
2014-12-30 15:18 ` Carlos R. Mafra
2015-01-01 20:40 ` Andreas Mohr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101204045.GA14006@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=andreas.noever@gmail.com \
--cc=crmafra2@gmail.com \
--cc=crmafra@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rafael.j.wysocki@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®