From: David Miller <davem@davemloft.net>
To: me@mortis.eu
Cc: linux-kernel@vger.kernel.org, jitendra.kalsaria@qlogic.com,
ron.mercer@qlogic.com, linux-driver@qlogic.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] Fix an infinite retry-loop
Date: Sun, 04 Jan 2015 23:48:38 -0500 (EST) [thread overview]
Message-ID: <20150104.234838.596521437683943688.davem@davemloft.net> (raw)
In-Reply-To: <1420394696-20099-1-git-send-email-me@mortis.eu>
From: Giel van Schijndel <me@mortis.eu>
Date: Sun, 4 Jan 2015 19:04:55 +0100
> This was clearly intended as a retry-10-times loop, but due to the
> absence of code incrementing the loop-counter it was practically a
> retry-forever loop.
>
> Rewritten it as a for-loop as well to make the loop-counter increment
> (as well as its potential absence) easier to spot.
Besides missing the Signoff, you also did not write your
Subject line properly.
You should format it as:
Subject: [PATCH] ${SUBSYSTEM_PREFIX}: Description.
Where ${SUBSYSTEM_PREFIX} should be "qlogic: " in this
case.
Do not fix this by replying to this email, instead make a new
fresh patch posting to the lists.
This also applied to all of your other submissions, they all
need to be fixed up in this manner at the very least.
next prev parent reply other threads:[~2015-01-05 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 18:04 Giel van Schijndel
2015-01-04 23:04 ` Giel van Schijndel
2015-01-05 4:48 ` David Miller [this message]
2015-01-07 18:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104.234838.596521437683943688.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@mortis.eu \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®