From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Ning Zhou <zhou.ning.gd@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
monamagarwal123@gmail.com, gulsah.1004@gmail.com,
daniel.dy.ngu@gmail.com, dh.herrmann@gmail.com,
josh@joshtriplett.org, linux-kernel@vger.kernel.org, teg@jklm.no,
sjw0410@gmail.com, dilekuzulmez@gmail.com, davem@davemloft.net
Subject: Re: [PATCH] staging: gdm724x: fix coding style issues
Date: Sun, 4 Jan 2015 02:27:13 +0100 [thread overview]
Message-ID: <20150104012713.GD25819@t400> (raw)
In-Reply-To: <1420301035-29052-1-git-send-email-zhou.ning.gd@gmail.com>
On 01/03, Ning Zhou wrote:
> Signed-off-by: Ning Zhou <zhou.ning.gd@gmail.com>
You need to describe your changes, a vague subject is not enough. Also
keep in mind that one patch shall address one category of stuff and
seems that yours could be separated into two.
thanks,
konrad
> ---
> drivers/staging/gdm724x/gdm_lte.c | 3 ++-
> drivers/staging/gdm724x/gdm_mux.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index 73eede1..7c4a77b 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
> icmp6_out.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT;
> icmp6_out.icmp6_code = 0;
> icmp6_out.icmp6_cksum = 0;
> - icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); /* R=0, S=1, O=1 */
> + /* R=0, S=1, O=1 */
> + icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000);
>
> ns = (struct neighbour_solicitation *)
> (skb_in->data + mac_header_len +
> diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
> index b5b063a..d1ab996 100644
> --- a/drivers/staging/gdm724x/gdm_mux.c
> +++ b/drivers/staging/gdm724x/gdm_mux.c
> @@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
> static void do_rx(struct work_struct *work)
> {
> struct mux_dev *mux_dev =
> - container_of(work, struct mux_dev , work_rx.work);
> + container_of(work, struct mux_dev, work_rx.work);
> struct mux_rx *r;
> struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
> unsigned long flags;
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2015-01-04 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 16:03 Ning Zhou
2015-01-04 1:27 ` Konrad Zapalowicz [this message]
2015-01-04 7:17 ` Ning Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150104012713.GD25819@t400 \
--to=bergo.torino@gmail.com \
--cc=daniel.dy.ngu@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dh.herrmann@gmail.com \
--cc=dilekuzulmez@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
--cc=sjw0410@gmail.com \
--cc=teg@jklm.no \
--cc=zhou.ning.gd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome