From: Tejun Heo <tj@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: flex_proportions.c: Remove some unused functions
Date: Mon, 5 Jan 2015 08:23:01 -0500 [thread overview]
Message-ID: <20150105132301.GA15833@htj.dyndns.org> (raw)
In-Reply-To: <20150105084534.GA7056@quack.suse.cz>
On Mon, Jan 05, 2015 at 09:45:34AM +0100, Jan Kara wrote:
> On Sat 20-12-14 15:40:31, Rickard Strandqvist wrote:
> > Removes some functions that are not used anywhere:
> > prop_fraction_single() prop_local_destroy_single() prop_local_init_single() fprop_global_destroy()
> >
> > This was partially found by using a static code analysis program called cppcheck.
> This is the same situation as with lib/proportions.c. The functions are
> there for API completeness. As far as I'm looking the whole 'single'
> section is unused so ifdeffing it out might make sense (and also ifdeffing
> out fprop_inc_single() from include/linux/flex_proportions.h). Removing
> fprop_global_destroy() is IMO pointless churn.
I'll prolly use some of the now unused portion of the API to implement
per-memcg dirty ratio for cgroup writeback, so let's please leave it
alone for now.
Thanks.
--
tejun
prev parent reply other threads:[~2015-01-05 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 14:40 Rickard Strandqvist
2015-01-05 8:45 ` Jan Kara
2015-01-05 13:23 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105132301.GA15833@htj.dyndns.org \
--to=tj@kernel.org \
--cc=davem@davemloft.net \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®