mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kernfs: Fix kernfs_name_compare
Date: Mon, 5 Jan 2015 09:13:47 -0500	[thread overview]
Message-ID: <20150105141347.GH15833@htj.dyndns.org> (raw)
In-Reply-To: <1417819295-18865-1-git-send-email-linux@rasmusvillemoes.dk>

On Fri, Dec 05, 2014 at 11:41:33PM +0100, Rasmus Villemoes wrote:
> Returning a difference from a comparison functions is usually wrong
> (see acbbe6fbb240 "kcmp: fix standard comparison bug" for the long
> story). Here there is the additional twist that if the void pointers
> ns and kn->ns happen to differ by a multiple of 2^32,
> kernfs_name_compare returns 0, falsely reporting a match to the
> caller.
> 
> Technically 'hash - kn->hash' is ok since the hashes are restricted to
> 31 bits, but it's better to avoid that subtlety.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Acked-by: Tejun Heo <tj@kernel.org>

And this is a -stable material.  Greg, can you please pick this one
up?

Thanks.

-- 
tejun

  reply	other threads:[~2015-01-05 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 16:19 [PATCH] " Rasmus Villemoes
2014-12-04 16:53 ` Tejun Heo
2014-12-05 22:41 ` [PATCH v2] " Rasmus Villemoes
2015-01-05 14:13   ` Tejun Heo [this message]
2015-01-05 16:14     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105141347.GH15833@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®