From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbbAFJkU (ORCPT ); Tue, 6 Jan 2015 04:40:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51847 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754512AbbAFJjy (ORCPT ); Tue, 6 Jan 2015 04:39:54 -0500 Date: Tue, 6 Jan 2015 10:39:10 +0100 From: Jiri Olsa To: Sukadev Bhattiprolu Cc: Arnaldo Carvalho de Melo , Michael Ellerman , Paul Mackerras , dev@codyps.com, peterz@infradead.org, hbabu@us.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v6 2/4] tools/perf: extend format_alias() to include event parameters Message-ID: <20150106093910.GA24841@krava.brq.redhat.com> References: <1419234567-22784-1-git-send-email-sukadev@linux.vnet.ibm.com> <1419234567-22784-3-git-send-email-sukadev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419234567-22784-3-git-send-email-sukadev@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 21, 2014 at 11:49:25PM -0800, Sukadev Bhattiprolu wrote: > From: Cody P Schafer > > This causes `perf list pmu` to show parameters for parameterized events > like: > > pmu/event_name,param1=?,param2=?/ [Kernel PMU event] > > An example: > > hv_24x7/HPM_TLBIE__PHYS_CORE,core=?/ [Kernel PMU event] > > Changelog[v6] > [Jir Olsa, Sukadev Bhattiprolu] Drop the '$' sign and go back to > just printing whatevever sysfs provides (which is '=?') to identify > required parameters. sysfs also now uses parameters like 'core' > and 'vcpu' rather than 'starting_index'. > > Changelog[v5] > [Jiri Olsa, Peter Zijlstra] Use '$' to prefix parameterized events. > > Changelog[v4] > [Jiri Olsa] If the parameter for an event in sysfs is 'param=val', > have perf-list show the event as 'param=?' rather than 'val=?'. > > CC: Haren Myneni > CC: Cody P Schafer > Signed-off-by: Cody P Schafer > Signed-off-by: Sukadev Bhattiprolu > --- > tools/perf/util/pmu.c | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index cb516dd..d208fef 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -810,10 +810,35 @@ void perf_pmu__set_format(unsigned long *bits, long from, long to) > set_bit(b, bits); > } > > +static int sub_non_neg(int a, int b) > +{ > + if (b > a) > + return 0; > + return a - b; > +} > + > static char *format_alias(char *buf, int len, struct perf_pmu *pmu, > struct perf_pmu_alias *alias) > { > - snprintf(buf, len, "%s/%s/", pmu->name, alias->name); > + struct parse_events_term *term; > + int used = snprintf(buf, len, "%s/%s", pmu->name, alias->name); > + > + list_for_each_entry(term, &alias->terms, list) > + if (term->type_val == PARSE_EVENTS__TERM_TYPE_STR) > + used += snprintf(buf + used, sub_non_neg(len, used), > + ",%s=%s", term->config, > + term->val.str); why not display PARSE_EVENTS__TERM_TYPE_NUM as well? jirka