From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>,
dev@codyps.com, peterz@infradead.org, hbabu@us.ibm.com,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 1/4] tools/perf: support parsing parameterized events
Date: Tue, 6 Jan 2015 10:42:20 +0100 [thread overview]
Message-ID: <20150106094220.GB19868@krava.brq.redhat.com> (raw)
In-Reply-To: <20141223195850.GA26952@us.ibm.com>
On Tue, Dec 23, 2014 at 11:58:50AM -0800, Sukadev Bhattiprolu wrote:
> From a24b480ff54381a7e092597864cf615162afdd60 Mon Sep 17 00:00:00 2001
> From: Cody P Schafer <cody@linux.vnet.ibm.com>
> Date: Wed, 24 Sep 2014 12:27:15 -0700
> Subject: [PATCH 1/4] tools/perf: support parsing parameterized events
>
> Enable event specification like:
>
> pmu/event_name,param1=0x1,param2=0x4/
>
> Assuming that
>
> /sys/bus/event_source/devices/pmu/events/event_name
>
> Contains something like
>
> param2=?,bar=1,param1=?
>
> Changelog[v6]:
> [Jiri Olsa] Add a check to make sure that sysfs entries with
> parameters exactly match '=?'.
>
> Changelog[v4]:
> [Jiri Olsa] Merge to recent perf-core and fix a small conflict.
>
> Changelog[v3]:
> [Jiri Olsa] If the sysfs event file specifies 'param=val', make the
> usage 'hv_24x7/event,param=123/' rather than 'hv_24x7/event,val=123/'.
Acked-by: Jiri Olsa <jolsa@kernel.org>
I'm ok with whole patchset, with some nits for patch 2
that I've already sent out..
Would you mind sending v7 so we avoid confusion for Arnaldo
what to pick up?
thanks,
jirka
next prev parent reply other threads:[~2015-01-06 9:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 7:49 [PATCH v6 0/4] Add support for parametrized events Sukadev Bhattiprolu
2014-12-22 7:49 ` [PATCH v6 1/4] tools/perf: support parsing parameterized events Sukadev Bhattiprolu
2014-12-22 14:37 ` Jiri Olsa
2014-12-22 19:30 ` Sukadev Bhattiprolu
2014-12-23 9:55 ` Jiri Olsa
2014-12-23 19:58 ` Sukadev Bhattiprolu
2015-01-06 9:42 ` Jiri Olsa [this message]
2015-01-06 13:26 ` Arnaldo Carvalho de Melo
2014-12-22 7:49 ` [PATCH v6 2/4] tools/perf: extend format_alias() to include event parameters Sukadev Bhattiprolu
2015-01-06 9:39 ` Jiri Olsa
2015-01-07 23:41 ` Sukadev Bhattiprolu
2015-01-06 9:40 ` Jiri Olsa
2014-12-22 7:49 ` [PATCH v6 3/4] perf Documentation: add " Sukadev Bhattiprolu
2014-12-22 14:39 ` Jiri Olsa
2014-12-22 19:34 ` Sukadev Bhattiprolu
2014-12-23 9:51 ` Jiri Olsa
2014-12-23 19:59 ` Sukadev Bhattiprolu
2014-12-22 7:49 ` [PATCH v6 4/4] tools/perf: Document parameterized and symbolic events Sukadev Bhattiprolu
2014-12-22 14:43 ` Jiri Olsa
2014-12-22 19:45 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106094220.GB19868@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=dev@codyps.com \
--cc=hbabu@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®