mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Felipe Balbi <balbi@ti.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Linux ARM Kernel Mailing List"
	<linux-arm-kernel@lists.infradead.org>,
	"Linux OMAP Mailing List" <linux-omap@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Peter Kümmel" <syntheticpp@gmx.net>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] irqchip: omap-intc: fix legacy DMA regression
Date: Tue, 6 Jan 2015 22:00:29 -0500	[thread overview]
Message-ID: <20150107030029.GE24989@titan.lakedaemon.net> (raw)
In-Reply-To: <1420576688-10604-1-git-send-email-balbi@ti.com>

On Tue, Jan 06, 2015 at 02:38:08PM -0600, Felipe Balbi wrote:
> commit 55601c9f2467 (arm: omap: intc: switch over
> to linear irq domain) introduced a regression with
> SDMA legacy driver because that driver strictly depends
> on INTC's IRQs starting at NR_IRQs. Aparently
> irq_domain_add_linear() won't guarantee that, since we see
> a 7 IRQs difference when booting with and without the
> commit cited above.
> 
> Until arch/arm/plat-omap/dma.c is properly fixed, we
> must maintain OMAP2/3 using irq_domain_add_legacy().
> 
> A FIXME note was added so people know to delete that
> code once that legacy DMA driver is fixed up.
> 
> Fixes: 55601c9f2467 (arm: omap: intc: switch over to linear irq domain)
> Cc: <stable@vger.kernel.org> # v3.18
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Tested-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/irqchip/irq-omap-intc.c | 26 +++++++++++++++++++++-----
>  1 file changed, 21 insertions(+), 5 deletions(-)

Applied to irqchip/urgent.  Thanks for taking care of the Fixes and
stable tags!

thx,

Jason.

  reply	other threads:[~2015-01-07  3:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150106123830.GD30544@fuloong-minipc.musicnaut.iki.fi>
2015-01-06 16:51 ` [PATCH] " Felipe Balbi
2015-01-06 17:48   ` Aaro Koskinen
2015-01-06 17:52     ` Tony Lindgren
2015-01-06 18:05   ` Russell King - ARM Linux
2015-01-06 18:24     ` Aaro Koskinen
2015-01-06 18:30     ` Tony Lindgren
2015-01-06 20:38   ` [PATCH v2] " Felipe Balbi
2015-01-07  3:00     ` Jason Cooper [this message]
2015-01-19 18:34       ` Tony Lindgren
2015-01-07 11:12   ` [PATCH] " Peter Kümmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107030029.GE24989@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=aaro.koskinen@iki.fi \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=ssantosh@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syntheticpp@gmx.net \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®