From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754952AbbAGIld (ORCPT <rfc822;w@1wt.eu>);
	Wed, 7 Jan 2015 03:41:33 -0500
Received: from cantor2.suse.de ([195.135.220.15]:60025 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751159AbbAGIlb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 7 Jan 2015 03:41:31 -0500
Date: Wed, 7 Jan 2015 09:41:25 +0100
From: Jan Kara <jack@suse.cz>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Tejun Heo <tj@kernel.org>, kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
        Jan Kara <jack@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Maxim Patlasov <MPatlasov@parallels.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Derek Basehore <dbasehore@chromium.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] writeback: fix simple_return.cocci warnings
Message-ID: <20150107084125.GB22048@quack.suse.cz>
References: <201501071230.5cIaA8Xy%fengguang.wu@intel.com>
 <20150107042535.GA36032@athens>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150107042535.GA36032@athens>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed 07-01-15 12:25:35, Wu Fengguang wrote:
> mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
  Looks good.
Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
> ---
> 
>  backing-dev.c |    8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write
>  
>  int bdi_init(struct backing_dev_info *bdi)
>  {
> -	int err;
> -
>  	bdi->dev = NULL;
>  
>  	bdi->min_ratio = 0;
> @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd
>  	INIT_LIST_HEAD(&bdi->bdi_list);
>  	INIT_LIST_HEAD(&bdi->work_list);
>  
> -	err = bdi_wb_init(&bdi->wb, bdi);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return bdi_wb_init(&bdi->wb, bdi);
>  }
>  EXPORT_SYMBOL(bdi_init);
>  
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR