From: Guenter Roeck <linux@roeck-us.net>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Benoit Cousson <bcousson@baylibre.com>,
Patrick Titiano <ptitiano@baylibre.com>,
LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCHv2] hwmon: (ina2xx) implement update_interval attribute for ina226
Date: Fri, 9 Jan 2015 09:57:34 -0800 [thread overview]
Message-ID: <20150109175734.GA30337@roeck-us.net> (raw)
In-Reply-To: <CAMpxmJV7O_DqTx66N5t2dWc8JqpqFmvQS+figEOVm9P4DYoZNg@mail.gmail.com>
On Fri, Jan 09, 2015 at 03:45:27PM +0100, Bartosz Golaszewski wrote:
> 2015-01-09 15:34 GMT+01:00 Guenter Roeck <linux@roeck-us.net>:
> > Unfortunately that only applies to INA226 and not INA219, where the time is
> > static
> > (at least so far).
>
> Oops, I must have missed this one.
>
> > I think we'll need to store the time in ina2xx_data and use the old
> > (constant)
> > value for ina219. Maybe add another variable into the configuration data
> > for the initial value and copy it from there during probe.
>
> I tried to avoid adding another variable used by ina226 only, but
> well. It's kind of dull that these chips are supported by a single
> driver - their configuration register layout is completely different.
>
On the other side the data registers are the same. There is always some
trade-off.
Guenter
prev parent reply other threads:[~2015-01-09 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 12:03 Bartosz Golaszewski
2015-01-09 14:34 ` Guenter Roeck
2015-01-09 14:45 ` Bartosz Golaszewski
2015-01-09 17:57 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109175734.GA30337@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=ptitiano@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome