From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next 3/3 V2] mei: add reference counting for me clients
Date: Fri, 9 Jan 2015 14:51:53 -0800 [thread overview]
Message-ID: <20150109225153.GA20890@kroah.com> (raw)
In-Reply-To: <1417090049-23219-3-git-send-email-tomas.winkler@intel.com>
On Thu, Nov 27, 2014 at 02:07:29PM +0200, Tomas Winkler wrote:
> To support dynamic addition and removal of
> me clients we add reference counter.
>
> Update kdoc with locking requirements.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
This patch adds build warnings, I can't take it:
drivers/misc/mei/bus.c: In function ‘___mei_cl_send’:
drivers/misc/mei/bus.c:276:3: warning: ‘cb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
mei_io_cb_free(cb);
^
drivers/misc/mei/bus.c:273:2: warning: ‘me_cl’ may be used uninitialized in this function [-Wmaybe-uninitialized]
mei_me_cl_put(me_cl);
^
Please be more careful.
next prev parent reply other threads:[~2015-01-09 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 12:07 [char-misc-next 1/3 V2] mei: add ABI documentation for fw_status exported through sysfs Tomas Winkler
2014-11-27 12:07 ` [char-misc-next 2/3 V2] mei: bus: use ssize_t as the return type for send and receive Tomas Winkler
2014-11-27 12:07 ` [char-misc-next 3/3 V2] mei: add reference counting for me clients Tomas Winkler
2015-01-09 22:51 ` Greg KH [this message]
2015-01-10 22:01 ` Winkler, Tomas
2014-12-18 9:37 ` [char-misc-next 1/3 V2] mei: add ABI documentation for fw_status exported through sysfs Winkler, Tomas
2014-12-18 22:15 ` gregkh
2014-12-18 22:46 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109225153.GA20890@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome