From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbbAKQ5O (ORCPT ); Sun, 11 Jan 2015 11:57:14 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50136 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbbAKQ5K (ORCPT ); Sun, 11 Jan 2015 11:57:10 -0500 Date: Sun, 11 Jan 2015 08:57:08 -0800 From: Greg Kroah-Hartman To: Joe Perches Cc: devel@driverdev.osuosl.org, Benjamin Romer , David Kershner , LKML , sparmaintainer@unisys.com Subject: Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err Message-ID: <20150111165708.GA27161@kroah.com> References: <1420945742.16787.12.camel@perches.com> <20150111041319.GB22334@kroah.com> <1420952121.32288.1.camel@perches.com> <20150111052428.GC24038@kroah.com> <1420954353.32288.3.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1420954353.32288.3.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 10, 2015 at 09:32:33PM -0800, Joe Perches wrote: > On Sat, 2015-01-10 at 21:24 -0800, Greg Kroah-Hartman wrote: > > On Sat, Jan 10, 2015 at 08:55:21PM -0800, Joe Perches wrote: > > > On Sat, 2015-01-10 at 20:13 -0800, Greg Kroah-Hartman wrote: > > > > On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote: > > > > > Use the normal logging facility instead of a new macro. > > > > > > > > > > Miscellanea: > > > > > > > > > > o Realign arguments > > > > > o Remove unnecessary alloc error messages as alloc failures > > > > > already emits a generic OOM message with a dump_stack > > > > > o Add missing newlines to these messages to avoid interleaving > > > > > o Spelling/typo fixes in those messages > > > [] > > > > I rejected the other patch that did much this same thing, almost all of > > > > these should be converted to use dev_* calls instead of pr_* calls, as > > > > this is a driver, and drivers should always have access to a struct > > > > device. If not, they need to be fixed. > > > > > > Baby steps. > > > > > > This one prevents interleaving > > > and fixes typos. > > > > Yes, but converting it to dev_* at the same time saves a step, and gets > > it done properly. Leaving messages at pr_* levels takes away the > > checkpatch warning, which makes the code "seem" to be acceptable. > > I think you've not looked at the code very much. Oh I have :( > Many of these things can not be converted to dev_ > as there is not a single device there. And that needs to be fixed. > Many of these are error messages referring to busses that > support many devices. Those busses have controllers that are devices. > Converting them to dev_ piecemeal or wholesale > isn't possible. It will need to be done to get the code merged out of staging, so it better happen... thanks, greg k-h