From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbbALJuv (ORCPT ); Mon, 12 Jan 2015 04:50:51 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:42337 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbbALJut (ORCPT ); Mon, 12 Jan 2015 04:50:49 -0500 Date: Mon, 12 Jan 2015 10:50:46 +0100 From: Michal Hocko To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org, Rik van Riel , "Elifaz, Dana" , "Bridgman, John" , Daniel Forrest , Chris Clayton , Oded Gabbay Subject: Re: [PATCH] mm: fix corner case in anon_vma endless growing prevention Message-ID: <20150112095046.GB4877@dhcp22.suse.cz> References: <20150111135406.13266.42007.stgit@zurg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150111135406.13266.42007.stgit@zurg> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 11-01-15 16:54:06, Konstantin Khlebnikov wrote: > Fix for BUG_ON(anon_vma->degree) splashes in unlink_anon_vmas() > ("kernel BUG at mm/rmap.c:399!"). > > Anon_vma_clone() is usually called for a copy of source vma in destination > argument. If source vma has anon_vma it should be already in dst->anon_vma. > NULL in dst->anon_vma is used as a sign that it's called from anon_vma_fork(). > In this case anon_vma_clone() finds anon_vma for reusing. > > Vma_adjust() calls it differently and this breaks anon_vma reusing logic: > anon_vma_clone() links vma to old anon_vma and updates degree counters but > vma_adjust() overrides vma->anon_vma right after that. As a result final > unlink_anon_vmas() decrements degree for wrong anon_vma. > > This patch assigns ->anon_vma before calling anon_vma_clone(). > > Signed-off-by: Konstantin Khlebnikov > Fixes: 7a3ef208e662 ("mm: prevent endless growth of anon_vma hierarchy") > Tested-by: Chris Clayton > Tested-by: Oded Gabbay > Cc: Daniel Forrest > Cc: Michal Hocko > Cc: Rik van Riel Reviewed-by: Michal Hocko > --- > mm/mmap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 7b36aa7..12616c5 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -778,10 +778,12 @@ again: remove_next = 1 + (end > next->vm_end); > if (exporter && exporter->anon_vma && !importer->anon_vma) { > int error; > > + importer->anon_vma = exporter->anon_vma; > error = anon_vma_clone(importer, exporter); > - if (error) > + if (error) { > + importer->anon_vma = NULL; > return error; > - importer->anon_vma = exporter->anon_vma; > + } > } > } > > -- Michal Hocko SUSE Labs