From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbbALMhW (ORCPT ); Mon, 12 Jan 2015 07:37:22 -0500 Received: from verein.lst.de ([213.95.11.211]:41008 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbbALMhT (ORCPT ); Mon, 12 Jan 2015 07:37:19 -0500 Date: Mon, 12 Jan 2015 13:37:18 +0100 From: Christoph Hellwig To: Rickard Strandqvist Cc: Trond Myklebust , Weston Andros Adamson , Anna Schumaker , Boaz Harrosh , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfs: objlayout: objio_osd: Remove unused function Message-ID: <20150112123718.GC29325@lst.de> References: <1421000694-22451-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421000694-22451-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 11, 2015 at 07:24:54PM +0100, Rickard Strandqvist wrote: > Remove the function objio_alloc_deviceid_node() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. It needs to be wire up, just like the alloc_deviceid_node instances in other layout drivers. I'll send a proper fix.