From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [RFC 1/4] lockdep: additional lock specific information when dumping locks
Date: Mon, 12 Jan 2015 16:37:47 +0100 [thread overview]
Message-ID: <20150112153747.GE25256@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <54B3E466.2030006@oracle.com>
On Mon, Jan 12, 2015 at 10:12:38AM -0500, Sasha Levin wrote:
> The reason for my patch is simple:
That might have maybe been good changelog material?
> I'm fuzzing with hundreds of worker threads
> which at some point trigger a complete system lockup for some reason.
>
> When lockdep dumps the list of held locks it shows that pretty much every one
> of those threads is holding the lock which caused the lockup, which is incorrect
> because it considers locks in the process of getting acquired as "held".
>
> This is my solution to that issue. I wanted to know which one of the threads is
> really holding the lock rather than just waiting on it.
>
> Is there a better way to solve that problem?
Sure, think moar, if the accompanying stack trace is in the middle
of the blocking primitive, ignore the top held lock ;-)
Alternatively, make better/more use of lock_acquired() and track the
acquire vs acquired information in the held_lock (1 bit) and look at it
when printing.
next prev parent reply other threads:[~2015-01-12 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 14:57 Sasha Levin
2015-01-12 14:57 ` [RFC 2/4] locking/mutex: additional lock " Sasha Levin
2015-01-12 14:57 ` [RFC 3/4] locking/rwsem: " Sasha Levin
2015-01-12 14:57 ` [RFC 4/4] locking/spinlock: " Sasha Levin
2015-01-12 15:06 ` [RFC 1/4] lockdep: additional lock specific " Peter Zijlstra
2015-01-12 15:12 ` Sasha Levin
2015-01-12 15:37 ` Peter Zijlstra [this message]
2015-01-12 16:06 ` Sasha Levin
2015-01-12 16:23 ` Peter Zijlstra
2015-01-13 5:18 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112153747.GE25256@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome