From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051AbbALR7e (ORCPT ); Mon, 12 Jan 2015 12:59:34 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:60777 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbALR7d (ORCPT ); Mon, 12 Jan 2015 12:59:33 -0500 Date: Mon, 12 Jan 2015 09:59:20 -0800 From: Guenter Roeck To: Geert Uytterhoeven Cc: Stephen Rothwell , Linux-Next , "linux-kernel@vger.kernel.org" , Rob Clark , Daniel Vetter , Benjamin Herrenschmidt , "linuxppc-dev@lists.ozlabs.org" , linux-m68k Subject: Re: linux-next: Tree for Jan 12 (build failures: m68k, ppc) Message-ID: <20150112175920.GC19868@roeck-us.net> References: <20150112180322.003b44f2@canb.auug.org.au> <20150112162438.GA18723@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.54B40B84.01C4,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 4 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 12, 2015 at 05:27:08PM +0100, Geert Uytterhoeven wrote: > On Mon, Jan 12, 2015 at 5:24 PM, Guenter Roeck wrote: > > On Mon, Jan 12, 2015 at 06:03:22PM +1100, Stephen Rothwell wrote: > >> Hi all, > >> > >> Changes since 20150109: > >> > >> The usb-gadget-fixes tree gained a conflict against the usb.current tree. > >> > >> The net-next tree gained a build failure for which I reverted a commit. > >> > >> The pinctrl tree gained a build failure so I used the version from > >> next-20150109. > >> > >> The akpm tree lost a few patches that turned up elsewhere. > >> > >> Non-merge commits (relative to Linus' tree): 2202 > >> 2272 files changed, 69868 insertions(+), 38441 deletions(-) > >> > > > > Build failures, seen since next-20150109: > > m68k:allmodconfig > > powerpc:ppc6xx_defconfig > > > > Due to: > > ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > > > Caused by commit d34f20d6e2f (drm: Atomic modeset ioctl). > > Yeah, it needs a get_user() that supports 64-bit data. > Hi Geert, I assume you mean m68k, where 64 bit support for get_user has been disabled. The problem on powerpc is different though: __get_user_nocheck() and __get_user_check() use unsigned long __gu_val; followed by __get_user_size(__gu_val, __gu_addr, (size), __gu_err); __get_user_size() fails in if (size > sizeof(x)) (x) = __get_user_bad(); Presumably "unsigned long" is 32 bit on 32 bit powerpc, not 64 bit. Overall, the explicit 64-bit use of get_user() seems to be quite unusual. Thanks, Guenter