mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lambert.quentin@gmail.com
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] atm: remove deprecated use of pci api
Date: Tue, 13 Jan 2015 21:59:44 -0500 (EST)	[thread overview]
Message-ID: <20150113.215944.1703977685948196746.davem@davemloft.net> (raw)
In-Reply-To: <20150112161042.GA11374@sloth>

From: Quentin Lambert <lambert.quentin@gmail.com>
Date: Mon, 12 Jan 2015 17:10:42 +0100

> @@ -2246,7 +2246,8 @@ static int eni_init_one(struct pci_dev *pci_dev,
>  		goto err_disable;
>  
>  	zero = &eni_dev->zero;
> -	zero->addr = pci_alloc_consistent(pci_dev, ENI_ZEROES_SIZE, &zero->dma);
> +	zero->addr = dma_alloc_coherent(&pci_dev->dev, ENI_ZEROES_SIZE,
> +					&zero->dma, GFP_ATOMIC);
>  	if (!zero->addr)
>  		goto err_kfree;
>  

I really would like you to look at these locations and see if
GFP_KERNEL can be used instead of GFP_ATOMIC.  I bet that nearly
all of these can, and it is preferred.

Thanks.

  reply	other threads:[~2015-01-14  2:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 16:10 Quentin Lambert
2015-01-14  2:59 ` David Miller [this message]
2015-01-14 13:58   ` chas williams - CONTRACTOR
2015-01-14 14:25     ` Quentin Lambert
2015-01-14 14:47   ` David Laight
2015-01-16 13:57     ` [net-next PATCH v3 " chas williams - CONTRACTOR
2015-01-16 14:10       ` Quentin Lambert
2015-01-16 14:52         ` chas williams - CONTRACTOR
2015-01-16 14:54           ` Quentin Lambert
2015-01-18  5:28       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113.215944.1703977685948196746.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=lambert.quentin@gmail.com \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®