From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: LKML <linux-kernel@vger.kernel.org>, vvs@sw.ru
Subject: Re: Bug with jprobes and function graph tracer
Date: Tue, 13 Jan 2015 07:22:32 -0500 [thread overview]
Message-ID: <20150113072232.451c599b@gandalf.local.home> (raw)
In-Reply-To: <54B503F5.4020509@hitachi.com>
On Tue, 13 Jan 2015 20:39:33 +0900
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
> Yeah we should try to fix this, but not so high priority since jprobe
> is not used so frequently. I guess one easy solution is adding notrace
> to all jprobe handlers for hiding it from function-graph tracer.
> If there is a way to check a function is notrace or not, I can use that
> in register_jprobe and reject it if the handler is not "notrace"ed. :)
Adding notrace should be the last resort. Every notrace in the kernel
makes function tracing a little more useless. It bothers me even more
when notrace is added because of function graph tracing but the
function still works for function tracing.
I worked on this for the last few days and have a patch that fixes the
problem. I'll be posting it later today. It also uncovered another
unrelated bug that I worked on yesterday, otherwise I would have posted
these fixes already.
I have a fix for the other bug now but it needs to be cleaned up
(remove all the debugging prints from it). When that's complete I'll
post the patches and get them ready for mainline and stable.
Thanks,
-- Steve
next prev parent reply other threads:[~2015-01-13 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 17:20 Steven Rostedt
2015-01-13 11:39 ` Masami Hiramatsu
2015-01-13 12:22 ` Steven Rostedt [this message]
2015-01-13 12:46 ` Masami Hiramatsu
2015-01-14 13:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113072232.451c599b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®