From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd.bergmann@linaro.org>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH] driver core: property: support for generic property
Date: Tue, 13 Jan 2015 12:37:21 +0200 [thread overview]
Message-ID: <20150113103721.GB1856@kuha.fi.intel.com> (raw)
In-Reply-To: <3315410.c1hB71JUOk@vostro.rjw.lan>
On Tue, Jan 13, 2015 at 10:35:09AM +0100, Rafael J. Wysocki wrote:
> > @@ -51,13 +175,6 @@ EXPORT_SYMBOL_GPL(fwnode_property_present);
> > (val) ? of_property_read_##type##_array((node), (propname), (val), (nval)) \
> > : of_property_count_elems_of_size((node), (propname), sizeof(type))
> >
> > -#define DEV_PROP_READ_ARRAY(_dev_, _propname_, _type_, _proptype_, _val_, _nval_) \
> > - IS_ENABLED(CONFIG_OF) && _dev_->of_node ? \
> > - (OF_DEV_PROP_READ_ARRAY(_dev_->of_node, _propname_, _type_, \
> > - _val_, _nval_)) : \
> > - acpi_dev_prop_read(ACPI_COMPANION(_dev_), _propname_, \
> > - _proptype_, _val_, _nval_)
> > -
>
> The macro was used here for a reason. Can't you replace it with an extended
> macro instead?
OK, I'll change it.
Thanks,
--
heikki
prev parent reply other threads:[~2015-01-13 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 11:15 Heikki Krogerus
2015-01-13 9:35 ` Rafael J. Wysocki
2015-01-13 9:37 ` Heikki Krogerus
2015-01-13 10:37 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113103721.GB1856@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=arnd.bergmann@linaro.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®