From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbbAMM1o (ORCPT ); Tue, 13 Jan 2015 07:27:44 -0500 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:36810 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752065AbbAMM1b (ORCPT ); Tue, 13 Jan 2015 07:27:31 -0500 Date: Tue, 13 Jan 2015 12:27:15 +0000 From: Russell King - ARM Linux To: Philipp Zabel Cc: Jean-Francois Moine , Andrew Jackson , Jyri Sarha , Mark Brown , Dave Airlie , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Message-ID: <20150113122715.GP12302@n2100.arm.linux.org.uk> References: <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> <20150112175705.GN12302@n2100.arm.linux.org.uk> <1421151718.4519.24.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421151718.4519.24.camel@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 13, 2015 at 01:21:58PM +0100, Philipp Zabel wrote: > I wonder if it wouldn't be nicer to have the AP# and type in the device > tree and then calculate the register value from that in the driver. > > port@1 { > reg = <1>; /* AP1 */ > nxp,audio-port = "i2s"; > tda998x_i2s: endpoint { > remote-endpoint = <&audio1_i2s>; > }; > }; What about the case where we have 4 I2S streams being supplied to the device on four separate AP inputs? -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.