Re: [PATCH 2/3] jbd: drop jbd_ENOSYS debug

[Jan Kara <jack@suse.cz>]

On Wed 14-01-15 22:59:13, Davidlohr Bueso wrote:
> A quick search shows that there are no users, drop the
> macro for both jbd and jbd2.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> Cc: Jan Kara <jack@suse.cz>
  Thanks. I've added the patch to my tree.

								Honza

> ---
> My goal here was to just change how we set current state, however
> I realized that the function is not used.
> 
>  include/linux/jbd.h  | 9 ---------
>  include/linux/jbd2.h | 9 ---------
>  2 files changed, 18 deletions(-)
> 
> diff --git a/include/linux/jbd.h b/include/linux/jbd.h
> index 31229e0..d326152 100644
> --- a/include/linux/jbd.h
> +++ b/include/linux/jbd.h
> @@ -956,15 +956,6 @@ void __log_wait_for_space(journal_t *journal);
>  extern void	__journal_drop_transaction(journal_t *, transaction_t *);
>  extern int	cleanup_journal_tail(journal_t *);
>  
> -/* Debugging code only: */
> -
> -#define jbd_ENOSYS() \
> -do {								           \
> -	printk (KERN_ERR "JBD unimplemented function %s\n", __func__); \
> -	current->state = TASK_UNINTERRUPTIBLE;			           \
> -	schedule();						           \
> -} while (1)
> -
>  /*
>   * is_journal_abort
>   *
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 704b9a5..20e7f78 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1251,15 +1251,6 @@ void __jbd2_log_wait_for_space(journal_t *journal);
>  extern void __jbd2_journal_drop_transaction(journal_t *, transaction_t *);
>  extern int jbd2_cleanup_journal_tail(journal_t *);
>  
> -/* Debugging code only: */
> -
> -#define jbd_ENOSYS() \
> -do {								           \
> -	printk (KERN_ERR "JBD unimplemented function %s\n", __func__); \
> -	current->state = TASK_UNINTERRUPTIBLE;			           \
> -	schedule();						           \
> -} while (1)
> -
>  /*
>   * is_journal_abort
>   *
> -- 
> 2.1.2
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR