From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jia He <hejianet@gmail.com>
Cc: linux-kernel@vger.kernel.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration
Date: Fri, 16 Jan 2015 11:07:43 -0800 [thread overview]
Message-ID: <20150116190743.GA9827@hudson.localdomain> (raw)
In-Reply-To: <1421398692-21827-1-git-send-email-hejianet@gmail.com>
Jia He,
Your patch is looking better :-)
A few nits though.
On Fri, Jan 16, 2015 at 04:58:12PM +0800, Jia He wrote:
> These functions kportal_memhog_{alloc,free} aren't used outside of
^^^^^ Don't indent paragraphs, just use a line between paragraphs.
> this file, so making them static to suppress the sparse warnings about
> static declaration.
> Besides, this also fixes the space warning checked by checkpatch.pl
"Besides" doesn't sound right here. I would just say something like
"Also fix the space warning ..."
In your subject line it is helpful to add a version number so people
can tell that this is a new revision. For example: [PATCH v2].
git format-patch can add this automatically with the '-v' option.
[...]
--
- Jeremiah Mahler
prev parent reply other threads:[~2015-01-16 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 14:39 Jia He
2014-12-29 2:42 ` hejianet
2015-01-14 3:49 ` hejianet
2015-01-14 6:35 ` Jeremiah Mahler
2015-01-16 1:45 ` [PATCH 1/2] " Jia He
2015-01-16 1:45 ` [PATCH 2/2] staging: lustre: libcfs: fix space between function and open parenthesis Jia He
2015-01-16 6:21 ` Jeremiah Mahler
2015-01-16 8:58 ` [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration Jia He
2015-01-16 19:07 ` Jeremiah Mahler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116190743.GA9827@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hejianet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®