mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Poklop <peter.poklop@gmail.com>
Cc: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723au: fix space coding style issue in os_intfs.c
Date: Sat, 17 Jan 2015 06:58:46 -0800	[thread overview]
Message-ID: <20150117145846.GA26836@kroah.com> (raw)
In-Reply-To: <1421506365-9171-1-git-send-email-peter.poklop@gmail.com>

On Sat, Jan 17, 2015 at 03:52:45PM +0100, Peter Poklop wrote:
> From: Peter <peter.poklop@gmail.com>

This name doesn't match up with:

> 
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: space prohibited before semicolon
> 
> Signed-off-by: Peter Poklop <peter.poklop@gmail.com>

this name, why?

Please fix up and resend.

Or better yet, don't even include the first "From:" line, as it's not
needed in this case, right?

thanks,

greg k-h

  reply	other threads:[~2015-01-17 14:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-17 14:52 Peter Poklop
2015-01-17 14:58 ` Greg KH [this message]
2015-01-19 17:26 ` [PATCH v2] " Peter Poklop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150117145846.GA26836@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jes.Sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=peter.poklop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®