From: Kim Phillips <kim.phillips@freescale.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tudor Ambarus <tudor.ambarus@freescale.com>,
<linux-crypto@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Marek Vasut <marex@denx.de>,
Cristian Stoica <cristian.stoica@freescale.com>,
Horia Geanta <horia.geanta@freescale.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] crypto: caam - don't emit ICV check failures to dmesg
Date: Tue, 20 Jan 2015 12:43:10 -0600 [thread overview]
Message-ID: <20150120124310.ba1dd7a6454f65255c1ed713@freescale.com> (raw)
In-Reply-To: <20141211193018.2465016d545334a76c0f4bab@freescale.com>
ICV check failures are part of normal operation;
leave user notification up to the higher levels,
as is done in s/w algorithm implementations.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
drivers/crypto/caam/error.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c
index 66d73bf..33e41ea 100644
--- a/drivers/crypto/caam/error.c
+++ b/drivers/crypto/caam/error.c
@@ -151,10 +151,15 @@ static void report_ccb_status(struct device *jrdev, const u32 status,
else
snprintf(err_err_code, sizeof(err_err_code), "%02x", err_id);
- dev_err(jrdev, "%08x: %s: %s %d: %s%s: %s%s\n",
- status, error, idx_str, idx,
- cha_str, cha_err_code,
- err_str, err_err_code);
+ /*
+ * CCB ICV check failures are part of normal operation life;
+ * we leave the upper layers to do what they want with them.
+ */
+ if (err_id != JRSTA_CCBERR_ERRID_ICVCHK)
+ dev_err(jrdev, "%08x: %s: %s %d: %s%s: %s%s\n",
+ status, error, idx_str, idx,
+ cha_str, cha_err_code,
+ err_str, err_err_code);
}
static void report_jump_status(struct device *jrdev, const u32 status,
--
2.2.2
next parent reply other threads:[~2015-01-20 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1414686811-6527-1-git-send-email-tudor.ambarus@freescale.com>
[not found] ` <1414688107-8196-1-git-send-email-tudor.ambarus@freescale.com>
[not found] ` <20141106151714.GE4544@gondor.apana.org.au>
[not found] ` <20141204182245.f352ea22dc61ea6f65d85c62@freescale.com>
[not found] ` <20141211193018.2465016d545334a76c0f4bab@freescale.com>
2015-01-20 18:43 ` Kim Phillips [this message]
2015-01-21 8:57 ` Cristian Stoica
2015-01-26 2:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120124310.ba1dd7a6454f65255c1ed713@freescale.com \
--to=kim.phillips@freescale.com \
--cc=cristian.stoica@freescale.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=tudor.ambarus@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®