From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: support for repatching a function
Date: Tue, 20 Jan 2015 06:52:15 -0600 [thread overview]
Message-ID: <20150120125215.GC15916@treble.redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1501201051330.31639@pobox.suse.cz>
On Tue, Jan 20, 2015 at 10:56:33AM +0100, Miroslav Benes wrote:
> On Fri, 9 Jan 2015, Josh Poimboeuf wrote:
> > +struct klp_ops {
> > + struct list_head node;
> > + struct list_head func_stack;
> > + struct ftrace_ops fops;
> > +};
>
> I think it would be useful to add some comments for this structure and its
> members (similar to the last paragraph of the changelog above). Maybe it
> is useless now but the code is going to get complicated and it costs
> nothing...
Ok, thanks.
> Otherwise it looks ok to me (except for thing mentioned by Jiri).
>
> Thank you
>
> --
> Miroslav Benes
> SUSE Labs
--
Josh
prev parent reply other threads:[~2015-01-20 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 20:08 Josh Poimboeuf
2015-01-16 16:51 ` Jiri Kosina
2015-01-19 14:54 ` Josh Poimboeuf
2015-01-19 19:48 ` Jiri Kosina
2015-01-19 20:02 ` Josh Poimboeuf
2015-01-20 9:56 ` Miroslav Benes
2015-01-20 12:52 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120125215.GC15916@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome