From: Jiri Olsa <jolsa@redhat.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: perf: behavior of poll() changed in 3.18
Date: Tue, 20 Jan 2015 19:13:16 +0100 [thread overview]
Message-ID: <20150120181316.GA12860@krava.brq.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501201155380.18043@vincent-weaver-1.umelst.maine.edu>
On Tue, Jan 20, 2015 at 12:03:19PM -0500, Vince Weaver wrote:
> Hello
>
> Some of my code that used poll() on a perf_event fd broke sometime between
> 3.17 and current. (My perf_event_test validation testsuite caught this
> too but I haven't been running it as regularly as I should).
>
> I bisected this to:
>
> commit 179033b3e064d2cd3f5f9945e76b0a0f0fbf4883
> Author: Jiri Olsa <jolsa@kernel.org>
> Date: Thu Aug 7 11:48:26 2014 -0400
>
> perf: Add PERF_EVENT_STATE_EXIT state for events with exited task
>
>
> Before, when polling, my code would get a
> result=0/WIFEXITED()
> return when a child with events being polled exited.
>
> Now instead I get a
> result=1/POLLHUP
> return.
>
> Needless to say this broke my code. Is there a reason this change was
> made?
hi,
I made this change to get notification that monitored
process exited. We use it in 'perf record' to find out
that we have nothing more to monitor and quit.
The logic is to return POLLHUP (via poll syscall) when
the monitored process exits for the event.
Could you please share your test code?
thanks,
jirka
next prev parent reply other threads:[~2015-01-20 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 17:03 Vince Weaver
2015-01-20 18:13 ` Jiri Olsa [this message]
2015-01-21 6:06 ` Vince Weaver
2015-01-21 16:21 ` Jiri Olsa
2015-01-22 6:53 ` Vince Weaver
2015-01-22 13:34 ` Jiri Olsa
2015-01-22 18:09 ` Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120181316.GA12860@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome