mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Iulia Manda <iulia.manda21@gmail.com>
Cc: serge.hallyn@canonical.com,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	paulmck@linux.vnet.ibm.com, josh@joshtriplett.org,
	peterz@infradead.org, mhocko@suse.cz
Subject: Re: [PATCH] kernel: Conditionally support non-root users, groups and capabilities
Date: Wed, 21 Jan 2015 14:52:19 +0000	[thread overview]
Message-ID: <20150121145219.446d360c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20150120233308.GA6256@winterfell>

On Wed, 21 Jan 2015 01:33:08 +0200
Iulia Manda <iulia.manda21@gmail.com> wrote:

> There are a lot of embedded systems that run most or all of their functionality
> in init, running as root:root. For these systems, supporting multiple users is
> not necessary.

We probably shouldn't encourage such poor design ;-)

The proposed patch generates a whole mass of ifdefs all over the place.
If it's going to be done move all the functions in question together
somewhere logical and give them a single ifdef or a file of their own.

It also doesn't appear to be dropping all it should - why can't you
simply not compile in groups.c for example ? If you can't then it says
the patch is far from complete at this point.

Alan


  parent reply	other threads:[~2015-01-21 14:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 23:33 Iulia Manda
2015-01-21  0:05 ` Casey Schaufler
2015-01-21  0:50   ` Josh Triplett
2015-01-21  1:23     ` Casey Schaufler
2015-01-21  5:08       ` Josh Triplett
2015-01-21 14:52 ` One Thousand Gnomes [this message]
2015-01-21 16:31   ` josh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121145219.446d360c@lxorguk.ukuu.org.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=iulia.manda21@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=serge.hallyn@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®