From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754009AbbAUPdf (ORCPT ); Wed, 21 Jan 2015 10:33:35 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:48049 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbbAUPd1 (ORCPT ); Wed, 21 Jan 2015 10:33:27 -0500 Date: Wed, 21 Jan 2015 21:03:03 +0530 From: "Naveen N. Rao" To: Arnaldo Carvalho de Melo , mpe@ellerman.id.au Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, ananth@in.ibm.com Subject: Re: [RFC PATCH 0/8] Fix perf probe issues on powerpc Message-ID: <20150121153303.GM2245@naverao1-tp.ibm.com> References: <20150121125142.GC3420@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150121125142.GC3420@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15012115-1618-0000-0000-0000017C1994 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/01/21 09:51AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 09, 2014 at 11:03:58PM +0530, Naveen N. Rao escreveu: > > This patchset fixes various issues with perf probe on powerpc > > across ABIv1 and ABIv2: > > - in the presence of DWARF debug-info, > > - in the absence of DWARF, but with the symbol table, and > > - in the absence of debug-info, but with kallsyms. > > > > Applies cleanly on v3.18 and on -tip with minor changes to patch 6. > > Tested on ppc64 BE and LE. > > > > - Naveen > > > > Naveen N. Rao (8): > > kprobes: Fix kallsyms lookup across powerpc ABIv1 and ABIv2 > > perf probe powerpc: Fix symbol fixup issues due to ELF type > > perf probe: Improve detection of file/function name in the probe > > pattern > > perf probe powerpc: Handle powerpc dot symbols > > perf probe powerpc: Allow matching against dot symbols > > perf tools powerpc: Fix PPC64 ELF ABIv2 symbol decoding > > perf probe powerpc: Use DWARF info only if necessary > > perf probe powerpc: Fixup function entry if using kallsyms lookup > > Naveen, > > I saw several comments by Michael, have you tried to address > those comments and have you resubmitted this patchset? Hi Arnaldo, Yes. Please find v2 of this patchset here: http://thread.gmane.org/gmane.linux.kernel/1851128 I request you to kindly take another look and let me know if you have further questions. Michael, Looking forward to your feedback. Thanks! - Naveen