From: Nicholas Mc Guire <der.herr@hofr.at>
To: ???? <micky_ching@realsil.com.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Keerthimai Janarthanan <keerthimaipb@gmail.com>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabio Falzoi <fabio.falzoi84@gmail.com>,
Tina Johnson <tinajohnson.1234@gmail.com>,
Surya Seetharaman <surya.seetharaman9@gmail.com>
Subject: Re: [PATCH] staging: rts5028: use msecs_to_jiffies for timeouts
Date: Thu, 22 Jan 2015 10:01:01 +0100 [thread overview]
Message-ID: <20150122090101.GB27741@opentech.at> (raw)
In-Reply-To: <54C05500.8050809@realsil.com.cn>
On Thu, 22 Jan 2015, ???? wrote:
> the title should be 5208.
sorry - that was a typo - should this be
resubmitted for traceability or is that not
necessary ?
>
> On 01/19/2015 03:25 PM, Nicholas Mc Guire wrote:
> > This is only an API consolidation and should make things more readable
> >
> > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> > ---
> >
> > Converting milliseconds to jiffies by val * HZ / 1000 is technically
> > not wrong but msecs_to_jiffies(val) is the cleaner solution and handles
> > corner cases correctly.
> >
> > This patch was only compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> > CONFIG_RTS5208=m
> >
> > Patch is against 3.19.0-rc4 -next-20150116
> >
> > drivers/staging/rts5208/rtsx_transport.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> > index 756a968..dab1995 100644
> > --- a/drivers/staging/rts5208/rtsx_transport.c
> > +++ b/drivers/staging/rts5208/rtsx_transport.c
> > @@ -271,7 +271,7 @@ int rtsx_send_cmd(struct rtsx_chip *chip, u8 card, int timeout)
> >
> > /* Wait for TRANS_OK_INT */
> > timeleft = wait_for_completion_interruptible_timeout(
> > - &trans_done, timeout * HZ / 1000);
> > + &trans_done, msecs_to_jiffies(timeout));
> > if (timeleft <= 0) {
> > dev_dbg(rtsx_dev(chip), "chip->int_reg = 0x%x\n",
> > chip->int_reg);
> > @@ -431,7 +431,7 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
> > spin_unlock_irq(&rtsx->reg_lock);
> >
> > timeleft = wait_for_completion_interruptible_timeout(
> > - &trans_done, timeout * HZ / 1000);
> > + &trans_done, msecs_to_jiffies(timeout));
> > if (timeleft <= 0) {
> > dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
> > __func__, __LINE__);
> > @@ -455,7 +455,7 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card,
> > init_completion(&trans_done);
> > spin_unlock_irq(&rtsx->reg_lock);
> > timeleft = wait_for_completion_interruptible_timeout(
> > - &trans_done, timeout * HZ / 1000);
> > + &trans_done, msecs_to_jiffies(timeout));
> > if (timeleft <= 0) {
> > dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
> > __func__, __LINE__);
> > @@ -575,7 +575,7 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
> > spin_unlock_irq(&rtsx->reg_lock);
> >
> > timeleft = wait_for_completion_interruptible_timeout(
> > - &trans_done, timeout * HZ / 1000);
> > + &trans_done, msecs_to_jiffies(timeout));
> > if (timeleft <= 0) {
> > dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
> > __func__, __LINE__);
> > @@ -602,7 +602,7 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
> > init_completion(&trans_done);
> > spin_unlock_irq(&rtsx->reg_lock);
> > timeleft = wait_for_completion_interruptible_timeout(
> > - &trans_done, timeout * HZ / 1000);
> > + &trans_done, msecs_to_jiffies(timeout));
> > if (timeleft <= 0) {
> > dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
> > __func__, __LINE__);
> > @@ -688,7 +688,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
> >
> > /* Wait for TRANS_OK_INT */
> > timeleft = wait_for_completion_interruptible_timeout(
> > - &trans_done, timeout * HZ / 1000);
> > + &trans_done, msecs_to_jiffies(timeout));
> > if (timeleft <= 0) {
> > dev_dbg(rtsx_dev(chip), "Timeout (%s %d)\n",
> > __func__, __LINE__);
thx!
hofrat
next prev parent reply other threads:[~2015-01-22 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 7:25 Nicholas Mc Guire
2015-01-22 1:40 ` 敬锐
2015-01-22 9:01 ` Nicholas Mc Guire [this message]
2015-01-23 1:13 ` 敬锐
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122090101.GB27741@opentech.at \
--to=der.herr@hofr.at \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keerthimaipb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=sarah.a.sharp@linux.intel.com \
--cc=surya.seetharaman9@gmail.com \
--cc=tinajohnson.1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome