From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbbAVM5s (ORCPT ); Thu, 22 Jan 2015 07:57:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34456 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbbAVM5p (ORCPT ); Thu, 22 Jan 2015 07:57:45 -0500 Date: Thu, 22 Jan 2015 13:56:59 +0100 From: Jiri Olsa To: Matt Fleming Cc: Arnaldo Carvalho de Melo , Jiri Olsa , linux-kernel@vger.kernel.org, Peter Zijlstra , Andi Kleen , Vince Weaver , Vikas Shivappa , Kanaka Juvva , Ingo Molnar Subject: Re: Perf tests for hw events Message-ID: <20150122125658.GA2473@krava.brq.redhat.com> References: <20150122124014.GF12079@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150122124014.GF12079@codeblueprint.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 22, 2015 at 12:40:14PM +0000, Matt Fleming wrote: > Folks, > > In the process of writing perf support for Intel's Cache QoS Monitoring > feature [0] I've had to write my own userland tests to drive tools/perf > and indirectly the kernel internals. I'm now getting requests for these > tests from various people and it occurs to me that they should probably > live in the kernel tree. > > The tests I've got do a couple of things like setting up a perf_event > cgroup and assigning enough tasks to trigger the RMID recycling code in > the CQM driver, ensuring that we can run multiple events simultaneously > (that the event scheduling/rotation code works), etc. > > Does anything like this already exist for hw events? I couldn't find > anything specific to hw events from snooping around in tools/perf/tests. that's the only place for this kind of stuff.. and AFAIK we use just some basic HW events like cycles, or software events > > I propose we add some hw event tests to the kernel tree. These will > provide, > > - regression tests > - a source of documentation for how to use the events yes, yes and yes ;-) > We should only test those hw events that are present on a user's > machine; there's no sense in emulating things. agreed.. I remember we were discussing with Arnaldo the strengthening of the test framework.. so it would detect what tests are runable under current machine and priviledge IIRC we already have some CPU detection support: int __attribute__ ((weak)) get_cpuid(char *buffer, size_t sz); jirka > > Thoughts? > > [0] - https://lkml.kernel.org/r/1415999712-5850-1-git-send-email-matt@console-pimps.org > > -- > Matt Fleming, Intel Open Source Technology Center