From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf ui/tui: Show fatal error message only if exists
Date: Thu, 22 Jan 2015 16:23:15 +0100 [thread overview]
Message-ID: <20150122152315.GA32650@krava.brq.redhat.com> (raw)
In-Reply-To: <20150122150834.GA16455@danjae>
On Fri, Jan 23, 2015 at 12:08:34AM +0900, Namhyung Kim wrote:
SNIP
> > > "Press any key...", 0);
> >
> > looks like we display ui_helpline__last_msg also in ui/browsers/annotate.c
>
> Right, I also saw it.
>
> >
> > do we want to have some common function that unsets tui_helpline__set
> > so we're sure we dont get the message twice?
>
> I doubt that it's really needed.. The annotation code does not
> propagate an error so the wait_for_ok arg in ui__exit() will be always
> false. In addition, I think it's better to use ui__error() or
> ui__warning() directly at the point when something bad happened and we
> need to inform user.
ok..
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
next prev parent reply other threads:[~2015-01-22 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 6:40 Namhyung Kim
2015-01-20 12:49 ` Jiri Olsa
2015-01-22 15:08 ` Namhyung Kim
2015-01-22 15:23 ` Jiri Olsa [this message]
2015-01-28 15:10 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122152315.GA32650@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome