From: Borislav Petkov <bp@alien8.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: James Dingwall <james@dingwall.me.uk>, linux-kernel@vger.kernel.org
Subject: Re: Linux 3.18.2 / xen 4.4.1 dom0 - microcode oops
Date: Thu, 22 Jan 2015 16:30:02 +0100 [thread overview]
Message-ID: <20150122153002.GA3554@pd.tnic> (raw)
In-Reply-To: <54C10ED0.1010302@oracle.com>
On Thu, Jan 22, 2015 at 09:53:04AM -0500, Boris Ostrovsky wrote:
> Alternatively, we could return an error (-EINVAL?) from
> microcode_init() when either of these two conditions is true.
Yeah, this should be the right fix.
James, does that fix your issue? (It should.)
---
diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index 15c29096136b..36a83617eb21 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -552,7 +552,7 @@ static int __init microcode_init(void)
int error;
if (paravirt_enabled() || dis_ucode_ldr)
- return 0;
+ return -EINVAL;
if (c->x86_vendor == X86_VENDOR_INTEL)
microcode_ops = init_intel_microcode();
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-01-22 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 5:52 James Dingwall
2015-01-22 8:20 ` Borislav Petkov
2015-01-22 14:48 ` Boris Ostrovsky
2015-01-22 14:53 ` Boris Ostrovsky
2015-01-22 15:30 ` Borislav Petkov [this message]
2015-01-22 17:43 ` James Dingwall
2015-01-22 17:58 ` Borislav Petkov
2015-01-22 18:09 ` Boris Ostrovsky
2015-01-27 22:12 ` Borislav Petkov
2015-01-27 22:55 ` Boris Ostrovsky
2015-01-27 23:12 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122153002.GA3554@pd.tnic \
--to=bp@alien8.de \
--cc=boris.ostrovsky@oracle.com \
--cc=james@dingwall.me.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome