From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean-Francois Moine <moinejf@free.fr>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, Jyri Sarha <jsarha@ti.com>
Subject: Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support
Date: Fri, 23 Jan 2015 17:40:13 +0000 [thread overview]
Message-ID: <20150123174013.GV21293@sirena.org.uk> (raw)
In-Reply-To: <54C252F4.9000504@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On Fri, Jan 23, 2015 at 02:56:04PM +0100, Lars-Peter Clausen wrote:
> On 01/23/2015 01:15 PM, Jean-Francois Moine wrote:
> >>Your example is a relative simple one where you do not have any additional
> >>audio fabric on the board itself.
> >Right, and that's why I'd be glad to have quickly something in the
> >kernel. More properties could be added later as there would be requests.
> I'd agree if this was some kind of kernel internal stuff, but this is
> creating ABI and we have to maintain it forever. Rushing this in without
> proper discussion and consideration of the more complex use-cases is in my
> opinion not a good idea.
Just to repeat myself again: *please* try to provide more explanation
for your commits, the concerns Lars is raising above are among the
things that I'd have expected to be covered in a high quality changelog.
There is no explanation at all in the changelog regarding the goal here,
just statements that this is a graph based card without an actual card
node.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-23 17:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 19:27 [PATCH v2 0/3] ASoC: add audio card creation from graph of ports in DT Jean-Francois Moine
2015-01-20 18:47 ` [PATCH v2 1/3] ASoC: core: export snd_soc_get_dai_name Jean-Francois Moine
2015-01-20 19:16 ` [PATCH v2 3/3] ASoC: add generic dt-card support Jean-Francois Moine
2015-01-21 20:14 ` [alsa-devel] " Lars-Peter Clausen
2015-01-22 8:07 ` Jean-Francois Moine
2015-01-22 19:00 ` Mark Brown
2015-01-22 19:25 ` Lars-Peter Clausen
2015-01-23 12:15 ` Jean-Francois Moine
2015-01-23 13:56 ` Lars-Peter Clausen
2015-01-23 17:40 ` Mark Brown [this message]
2015-01-23 18:34 ` Jean-Francois Moine
2015-01-23 19:13 ` Mark Brown
2015-01-24 7:30 ` Jean-Francois Moine
2015-02-03 16:47 ` Mark Brown
2015-02-03 19:31 ` Jean-Francois Moine
2015-02-07 8:33 ` Mark Brown
2015-01-24 11:27 ` Lars-Peter Clausen
2015-01-24 13:18 ` Jean-Francois Moine
2015-01-26 11:53 ` Lars-Peter Clausen
2015-01-26 18:22 ` Jean-Francois Moine
2015-01-21 19:10 ` [PATCH v2 2/3] Documentation: of: Document audio graph bindings Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123174013.GV21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®