From: Jiri Olsa <jolsa@redhat.com>
To: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
Cc: Wang Nan <wangnan0@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Li Zefan <lizefan@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] perf: convert: fix duplicate field names and avoid reserved keywords.
Date: Sat, 24 Jan 2015 17:39:25 +0100 [thread overview]
Message-ID: <20150124163925.GD17627@krava.brq.redhat.com> (raw)
In-Reply-To: <CA+jJMxsjh=H+f3z+cnJ6tFbmyrD-ArGSe7agVVvc4tird8MdHw@mail.gmail.com>
On Fri, Jan 23, 2015 at 05:40:02PM -0500, Jérémie Galarneau wrote:
SNIP
> > bt_ctf_clock_create() with the checked name and then free it. However, it is hacky
> > and I think you won't like it.
>
> The prospect of seeing that code has convinced me to introduce
> int bt_ctf_validate_identifier(const char *identifier);
>
> commit 654c1444b546fd79b209288b93ed4e87d9bb8a2b
> Author: Jérémie Galarneau <jeremie.galarneau@efficios.com>
> Date: Fri Jan 23 16:24:52 2015 -0500
>
> Add utility function to validate CTF identifiers
>
> Introduces bt_ctf_validate_identifier() which validates a given
> identifier against the list of CTF reserved keywords.
>
> This function may evolve to perform additional validity checks in
> the future as the CTF specification moves forward.
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
>
>
> Does that take care of the problem?
seems good to me, thanks
jirka
next prev parent reply other threads:[~2015-01-24 16:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 11:07 [PATCH 0/2] perf: convert: two patches for converting syscall tracepoitns Wang Nan
2015-01-20 11:07 ` [PATCH 1/2] perf: convert: fix duplicate field names Wang Nan
2015-01-20 13:06 ` Jiri Olsa
2015-01-21 3:23 ` [PATCH 1/2] perf: convert: fix duplicate field names and avoid reserved keywords Wang Nan
2015-01-21 11:16 ` Wang Nan
2015-01-21 14:19 ` Jiri Olsa
2015-01-21 14:25 ` Steven Rostedt
2015-01-21 14:32 ` Jiri Olsa
2015-01-22 5:35 ` [PATCH RFC 0/2] tools lib traceevent: introduces priv field to struct format_field Wang Nan
2015-01-22 5:36 ` [PATCH RFC 1/2] tools lib traceevent: add priv field to truct format_field Wang Nan
2015-01-22 5:36 ` [PATCH RFC 2/2] perf: convert: fix duplicate field names and avoid reserved keywords Wang Nan
2015-01-22 13:27 ` Jiri Olsa
2015-01-23 1:57 ` Wang Nan
2015-01-23 2:53 ` Wang Nan
2015-01-23 8:44 ` Jiri Olsa
2015-01-23 8:45 ` Jiri Olsa
2015-01-23 22:40 ` Jérémie Galarneau
2015-01-24 16:39 ` Jiri Olsa [this message]
2015-01-26 11:11 ` Wang Nan
2015-01-21 14:11 ` [PATCH 1/2] " Jiri Olsa
2015-01-21 15:56 ` Jérémie Galarneau
2015-01-22 1:38 ` Wang Nan
2015-01-22 3:14 ` Jérémie Galarneau
2015-01-22 3:21 ` Wang Nan
2015-01-23 20:45 ` Mathieu Desnoyers
2015-01-20 11:07 ` [PATCH 2/2] perf: convert: fix signess of value Wang Nan
2015-01-20 13:06 ` [PATCH 0/2] perf: convert: two patches for converting syscall tracepoitns Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150124163925.GD17627@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=jeremie.galarneau@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome