From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755106AbbAZNhh (ORCPT ); Mon, 26 Jan 2015 08:37:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52647 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbbAZNhf (ORCPT ); Mon, 26 Jan 2015 08:37:35 -0500 Date: Mon, 26 Jan 2015 14:37:33 +0100 From: Michal Hocko To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: fix static checker warning Message-ID: <20150126133733.GA22689@dhcp22.suse.cz> References: <1422276248-40456-1-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422276248-40456-1-git-send-email-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 26-01-15 14:44:08, Kirill A. Shutemov wrote: > The patch "mm: remove rest usage of VM_NONLINEAR and pte_file()" from > Jan 17, 2015, leads to the following static checker warning: > > mm/memcontrol.c:4794 mc_handle_file_pte() > warn: passing uninitialized 'pgoff' > > After the patch, the only case when mc_handle_file_pte() called is > pte_none(ptent). The 'if' check is redundant and lead to the warning. > Let's drop it. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Dan Carpenter Acked-by: Michal Hocko > --- > mm/memcontrol.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index cd42f14d138a..a6140c0764f4 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4792,8 +4792,7 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma, > return NULL; > > mapping = vma->vm_file->f_mapping; > - if (pte_none(ptent)) > - pgoff = linear_page_index(vma, addr); > + pgoff = linear_page_index(vma, addr); > > /* page is moved even if it's not RSS of this task(page-faulted). */ > #ifdef CONFIG_SWAP > -- > 2.1.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs