From: Peter Zijlstra <peterz@infradead.org>
To: Jason Low <jason.low2@hp.com>
Cc: Ingo Molnar <mingo@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Scott J Norton <scott.norton@hp.com>,
Chegu Vinod <chegu_vinod@hp.com>,
Aswin Chandramouleeswaran <aswin@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] sched, timer: Use atomics for thread_group_cputimer stats
Date: Mon, 26 Jan 2015 18:12:00 +0100 [thread overview]
Message-ID: <20150126171200.GB23038@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1422056755.2436.36.camel@j-VirtualBox>
On Fri, Jan 23, 2015 at 03:45:55PM -0800, Jason Low wrote:
> On a side note, if we just move the cputimer->running = 1 to after the
> call to update_gt_cputime in thread_group_cputimer(), then we don't have
> to worry about concurrent adds occuring in this function?
Yeah, maybe.. There are a few races there, but I figure that because we
already test cputimer->running outside of cputimer->lock they're already
possible.
next prev parent reply other threads:[~2015-01-26 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 3:31 Jason Low
2015-01-23 8:57 ` Peter Zijlstra
2015-01-23 9:25 ` Peter Zijlstra
2015-01-23 19:23 ` Jason Low
2015-01-23 20:08 ` Peter Zijlstra
2015-01-23 23:39 ` Jason Low
2015-01-23 23:45 ` Jason Low
2015-01-26 17:12 ` Peter Zijlstra [this message]
2015-01-23 9:33 ` Peter Zijlstra
2015-01-23 18:07 ` Jason Low
2015-01-23 20:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126171200.GB23038@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aswin@hp.com \
--cc=chegu_vinod@hp.com \
--cc=fweisbec@gmail.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=scott.norton@hp.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®