From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757593AbbA0Hzl (ORCPT ); Tue, 27 Jan 2015 02:55:41 -0500 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:54289 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544AbbA0Hzh (ORCPT ); Tue, 27 Jan 2015 02:55:37 -0500 X-Original-SENDERIP: 10.177.222.153 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Tue, 27 Jan 2015 16:56:53 +0900 From: Joonsoo Kim To: Akinobu Mita Cc: Andrew Morton , josh@joshtriplett.org, Kim Phillips , Johannes Weiner , Minchan Kim , Rik van Riel , Sasha Levin , Al Viro , Konstantin Khlebnikov , Jens Axboe , linux-mm@kvack.org, LKML , linuxppc-dev Subject: Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Message-ID: <20150127075653.GA11358@js1304-P5Q-DELUXE> References: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> <20150120230150.GA14475@cloud> <20150120160738.edfe64806cc8b943beb1dfa0@linux-foundation.org> <20150122014550.GA21444@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150122014550.GA21444@js1304-P5Q-DELUXE> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 22, 2015 at 10:45:51AM +0900, Joonsoo Kim wrote: > On Wed, Jan 21, 2015 at 09:57:59PM +0900, Akinobu Mita wrote: > > 2015-01-21 9:07 GMT+09:00 Andrew Morton : > > > On Tue, 20 Jan 2015 15:01:50 -0800 josh@joshtriplett.org wrote: > > > > > >> On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: > > >> > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on > > >> > ppc. Fix building the generic kernel_map_pages() implementation in > > >> > this case: > > >> > > > >> > LD init/built-in.o > > >> > mm/built-in.o: In function `free_pages_prepare': > > >> > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > > >> > mm/built-in.o: In function `prep_new_page': > > >> > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > > >> > mm/built-in.o: In function `map_pages': > > >> > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > > >> > make: *** [vmlinux] Error 1 > > > > kernel_map_pages() is static inline function since commit 031bc5743f15 > > ("mm/debug-pagealloc: make debug-pagealloc boottime configurable"). > > > > But there is old declaration in 'arch/powerpc/include/asm/cacheflush.h'. > > Removing it or changing s/kernel_map_pages/__kernel_map_pages/ in this > > header file or something can fix this problem? > > > > The architecture which has ARCH_SUPPORTS_DEBUG_PAGEALLOC > > including PPC should not build mm/debug-pagealloc.o > > Yes, architecture with ARCH_SUPPORTS_DEBUG_PAGEALLOC should not build > mm/debug-pagealloc.o. I attach the patch to remove old declaration. > I hope it will fix Kim's problem. > > -------------->8------------------ > >From 7cb9d1ed8a785df152cb8934e187031c8ebd1bb2 Mon Sep 17 00:00:00 2001 > From: Joonsoo Kim > Date: Thu, 22 Jan 2015 10:28:58 +0900 > Subject: [PATCH] mm/debug_pagealloc: fix build failure on ppc and some other > archs > > Kim Phillips reported following build failure. > > LD init/built-in.o > mm/built-in.o: In function `free_pages_prepare': > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `prep_new_page': > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `map_pages': > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > make: *** [vmlinux] Error 1 > > Reason for this problem is that commit 031bc5743f15 > ("mm/debug-pagealloc: make debug-pagealloc boottime configurable") forgot > to remove old declaration of kernel_map_pages() in some architectures. > This patch removes them to fix build failure. > > Reported-by: Kim Phillips > Signed-off-by: Joonsoo Kim Hello, Andrew. Could you take this patch? This patch is also needed to fix build failure. Thanks.