From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759199AbbA2XM4 (ORCPT ); Thu, 29 Jan 2015 18:12:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59157 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759131AbbA2XMz (ORCPT ); Thu, 29 Jan 2015 18:12:55 -0500 Date: Thu, 29 Jan 2015 15:12:54 -0800 From: Andrew Morton To: Andrey Ryabinin Cc: linux-kernel@vger.kernel.org, Dmitry Vyukov , Konstantin Serebryany , Dmitry Chernenkov , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Dave Hansen , Andi Kleen , x86@kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v10 13/17] mm: vmalloc: add flag preventing guard hole allocation Message-Id: <20150129151254.edc75e5ae20c3cafb55d88b1@linux-foundation.org> In-Reply-To: <1422544321-24232-14-git-send-email-a.ryabinin@samsung.com> References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1422544321-24232-1-git-send-email-a.ryabinin@samsung.com> <1422544321-24232-14-git-send-email-a.ryabinin@samsung.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jan 2015 18:11:57 +0300 Andrey Ryabinin wrote: > For instrumenting global variables KASan will shadow memory > backing memory for modules. So on module loading we will need > to allocate shadow memory and map it at exact virtual address. I don't understand. What does "map it at exact virtual address" mean? > __vmalloc_node_range() seems like the best fit for that purpose, > except it puts a guard hole after allocated area. Why is the guard hole a problem? More details needed in this changelog, please.