From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757278AbbA2Uoq (ORCPT ); Thu, 29 Jan 2015 15:44:46 -0500 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:51729 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750749AbbA2Uop (ORCPT ); Thu, 29 Jan 2015 15:44:45 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:981:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3873:3874:5007:6117:6119:6120:6261:6299:7875:7901:7903:10004:10400:10848:10967:11232:11658:11914:12043:12050:12291:12517:12519:12683:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: root75_2928aa6866b5b X-Filterd-Recvd-Size: 1759 Date: Thu, 29 Jan 2015 15:44:41 -0500 From: Steven Rostedt To: Josh Poimboeuf Cc: Satoru Takeuchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] ktest: console pty support Message-ID: <20150129154441.1b248e93@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Jan 2015 13:38:37 -0600 Josh Poimboeuf wrote: > These patches can be applied on top of yesterday's "ktest: restore tty settings > after closing console" patch. They create a pty pair for the console to > prevent the console child process from messing up ktest's tty settings. > > v2 changes: > - rebased onto the stty save/restore patch > - added a patch to enable user input to the console > > Josh Poimboeuf (2): > ktest: give console process a dedicated tty > ktest: enable user input to the console > > tools/testing/ktest/ktest.pl | 117 ++++++++++++++++++++++++++++++++++--------- > 1 file changed, 93 insertions(+), 24 deletions(-) > OK, I applied these and been using ktest since. But after one of my tests failed (got a bug report), I had no console. I think there's a die someplace that does not put everything back. Think you could find out where? -- Steve