From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758755AbbA2WrS (ORCPT ); Thu, 29 Jan 2015 17:47:18 -0500 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38459 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752664AbbA2WrQ (ORCPT ); Thu, 29 Jan 2015 17:47:16 -0500 Date: Fri, 30 Jan 2015 00:47:12 +0200 From: Heba Aamer To: Joe Perches Cc: devel@driverdev.osuosl.org, oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, gdonald@gmail.com, dmitry.eremin@intel.com, brilliantov@inbox.ru, tristan@lelong.xyz, HPDD-discuss@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf Message-ID: <20150129224712.GA23888@mohammed-Inspiron-3537> References: <20150128140533.GA14301@mohammed-Inspiron-3537> <1422496567.13127.29.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422496567.13127.29.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 28, 2015 at 05:56:07PM -0800, Joe Perches wrote: > On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: > > This patch fixes the following checkpatch.pl warning: > > Prefer seq_puts to seq_printf > > checkpatch is pretty stupid. > Please don't just do what it says. I checked checkpatch script and I found it only searches for a % in order not to give that warning, and it does not consider its escaping case %%. > > Look further and see what else can be improved. I will make a new patch modifying all the seq_printf statements in that file soon. Regards, Heba Aamer > > > diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c > [] > > @@ -364,7 +364,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v) > > else > > seq_printf(m, "%s ", cksum_name[i]); > > } > > - seq_printf(m, "\n"); > > + seq_puts(m, "\n"); > > This could be seq_putc > > > @@ -601,7 +601,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v) > > seq_printf(seq, "pending read pages: %d\n", > > atomic_read(&cli->cl_pending_r_pages)); > > > > - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n"); > > + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n"); > > seq_printf(seq, "pages per rpc rpcs %% cum %% |"); > > seq_printf(seq, " rpcs %% cum %%\n"); > > The seq_printf uses with %% could also be seq_puts > > > @@ -624,7 +624,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v) > > break; > > } > > > > - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n"); > > + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n"); > > seq_printf(seq, "rpcs in flight rpcs %% cum %% |"); > > seq_printf(seq, " rpcs %% cum %%\n"); > > seq_puts here too > > > @@ -647,7 +647,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v) > > break; > > } > > > > - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n"); > > + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n"); > > seq_printf(seq, "offset rpcs %% cum %% |"); > > seq_printf(seq, " rpcs %% cum %%\n"); > > > > and here > >