From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762808AbbA3Riu (ORCPT ); Fri, 30 Jan 2015 12:38:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54944 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbbA3Rit (ORCPT ); Fri, 30 Jan 2015 12:38:49 -0500 Date: Fri, 30 Jan 2015 18:38:30 +0100 From: Borislav Petkov To: Tony Luck Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Chen Gong Subject: Re: [PATCH] x86, mce: Always fall into mcelog path, regardless of what notifiers returned Message-ID: <20150130173830.GB1893@pd.tnic> References: <7567eecb772846677994ace8ba1ca0c58df1fb9a.1422638760.git.tony.luck@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7567eecb772846677994ace8ba1ca0c58df1fb9a.1422638760.git.tony.luck@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 09:29:47AM -0800, Tony Luck wrote: > This has been broken for a while - but we should not allow code > registered on the x86_mce_decoder_chain to bypass sending machine > check logs to /dev/mcelog. > > Signed-off-by: Tony Luck > --- > > Yes, we've had this conversation before and I wimped out and didn't > push the issue. But userspace is broken. People are complaining to > me that errors don't show up in /var/log/mcelog even though they > started the mcelog(8) daemon. We need to fix this differently - on AMD, mcelog is not needed as the decoding is done in the kernel. We could use mce_register_decode_chain() for callers to state what they want. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --