From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763164AbbA3TOP (ORCPT ); Fri, 30 Jan 2015 14:14:15 -0500 Received: from mail.skyhub.de ([78.46.96.112]:53701 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762839AbbA3TON (ORCPT ); Fri, 30 Jan 2015 14:14:13 -0500 Date: Fri, 30 Jan 2015 20:13:55 +0100 From: Borislav Petkov To: Tony Luck Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Borislav Petkov , Chen Gong Subject: Re: [PATCHv2] x86, mce: Kernel does full decoding for AMD, others still need /dev/mcelog reports Message-ID: <20150130191355.GH1451@pd.tnic> References: <20150130173830.GB1893@pd.tnic> <3d6a39202cff6415eeb0af7bff58f36ce879a253.1422641617.git.tony.luck@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3d6a39202cff6415eeb0af7bff58f36ce879a253.1422641617.git.tony.luck@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 30, 2015 at 10:16:48AM -0800, Tony Luck wrote: > We should only believe a NOTIFY_STOP on an AMD system. For others > we need to provide the error record out to a user level decoder > via /dev/mcelog. > > Signed-off-by: Tony Luck > --- > v2: Boris says: "on AMD, mcelog is not needed" > > arch/x86/kernel/cpu/mcheck/mce.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index d2c611699cd9..ea1bc1a05c07 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -151,12 +151,13 @@ void mce_log(struct mce *mce) > { > unsigned next, entry; > int ret = 0; > + struct cpuinfo_x86 *c = &boot_cpu_data; > > /* Emit the trace record: */ > trace_mce_record(mce); > > ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, mce); > - if (ret == NOTIFY_STOP) > + if (c->x86_vendor == X86_VENDOR_AMD && ret == NOTIFY_STOP) Yeah, ok, we do other vendor checks in mce.c already. Acked-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --