From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754878AbbBABgN (ORCPT ); Sat, 31 Jan 2015 20:36:13 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:32847 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193AbbBABgL (ORCPT ); Sat, 31 Jan 2015 20:36:11 -0500 Date: Sat, 31 Jan 2015 17:36:10 -0800 (PST) Message-Id: <20150131.173610.754001675443670809.davem@davemloft.net> To: m-karicheri2@ti.com Cc: w-kwok2@ti.com, mugunthanvnm@ti.com, tony@atomide.com, prabhakar.csengg@gmail.com, grygorii.strashko@ti.com, lokeshvutla@ti.com, mpa@pengutronix.de, lsorense@csclub.uwaterloo.ca, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone From: David Miller In-Reply-To: <1422573351-5603-2-git-send-email-m-karicheri2@ti.com> References: <1422573351-5603-1-git-send-email-m-karicheri2@ti.com> <1422573351-5603-2-git-send-email-m-karicheri2@ti.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sat, 31 Jan 2015 17:36:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Murali Karicheri Date: Thu, 29 Jan 2015 18:15:51 -0500 > NetCP on Keystone has cpsw ale function similar to other TI SoCs > and this driver is re-used. To allow both ti cpsw and keystone netcp > to re-use the driver, convert the cpsw ale to a module and configure > it through Kconfig option CONFIG_TI_CPSW_ALE. Currently it is statically > linked to both TI CPSW and NetCP and this causes issues when the above > drivers are built as dynamic modules. This patch addresses this issue > > While at it, fix the Makefile and code to build both netcp_core and > netcp_ethss as dynamic modules. This is needed to support arm allmodconfig. > This also requires exporting of API calls provided by netcp_core so that > both the above can be dynamic modules. > > Signed-off-by: Murali Karicheri Applied, thanks