From: Nicholas Mc Guire <der.herr@hofr.at>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling
Date: Mon, 2 Feb 2015 10:08:09 +0100 [thread overview]
Message-ID: <20150202090809.GB19706@opentech.at> (raw)
In-Reply-To: <54CF3CC5.6030204@nvidia.com>
On Mon, 02 Feb 2015, Laxman Dewangan wrote:
> On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote:
>> return type of wait_for_completion_timeout is unsigned long not int, this
>> patch adds an appropriate variable and fixes up the assignment.
>> As the string in dev_err already states "timeout" there
>> is little point in printing the 0 here.
>>
>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>
> Looks good to me. Thanks for fixing this.
> I think it is good if we fix the typo here also.
>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>
>>
>> + if (WARN_ON(dma_timeout == 0)) {
>> dev_err(tsd->dev,
>> - "spi trasfer timeout, err %d\n", ret);
>> + "spi trasfer timeout\n");
>
> trasfer -> transfer.
>
>
overlooked that - sorry - will fix it up and resubmit.
thx!
hofrat
next prev parent reply other threads:[~2015-02-02 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 13:00 Nicholas Mc Guire
2015-02-02 9:00 ` Laxman Dewangan
2015-02-02 9:08 ` Nicholas Mc Guire [this message]
2015-02-02 9:15 ` Laxman Dewangan
2015-02-01 13:00 Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202090809.GB19706@opentech.at \
--to=der.herr@hofr.at \
--cc=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=hofrat@osadl.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®