From: Mark Brown <broonie@kernel.org>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] spi: tegra20-sflash: cleanup wait_for_completion return handling
Date: Mon, 2 Feb 2015 11:40:11 +0000 [thread overview]
Message-ID: <20150202114011.GJ21293@sirena.org.uk> (raw)
In-Reply-To: <1422870712-2710-1-git-send-email-hofrat@osadl.org>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Mon, Feb 02, 2015 at 04:51:52AM -0500, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch adds an appropriate variable and fixes up the assignment.
> As the string in dev_err already states "timeout" there
> is little point in printing the 0 here.
This is labelled as patch 1/2 but appears to be sent as a single patch
and there's several other versions of patches for the Tegra code from
you at least some of which *do* include two patches. Please understand
that the purpose of numbering patches with posted patch series is to
allow the patches to be sorted within that series.
This is all confusing, I'm going to ignore all of these patches. Please
resubmit.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-02-02 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 9:51 Nicholas Mc Guire
2015-02-02 11:40 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202114011.GJ21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=hofrat@osadl.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®